The feedback of the review system in extension warehouse is not working.
In my experience a plugin is usually published in a day or so after submission if it passed the review process. However, on some occasions I have waited without getting any sort of feedback after the initial confirmation email that the extension is in the review queue. In the case of my most recently submitted extension I re-submitted it completely un-altered after 9 days since I thought it had gotten lost somewhere. In just a day I got this cryptic email response:
We’ve been reviewing your extension on the SketchUp Extension Warehouse. Thanks much for submitting it for review!
During the review, we found a few issues that we’d like you to address:
- Be kind to the undo stack. This includes wrapping a batch of changes into a single operation so that a single undo will roll back the batch of changes. Also avoid any changes that would mark the file as not saved that are not due to a user action, like modifying the model right after loading a file.
Here are the notes from the reviewer:
Looks like we still have the same problem.
Extension Warehouse Review Report
Extension: Eneroth Merge Layers
Author: Julia Christina Eneroth
Version ID: 2f71114e-660a-459b-b42d-43e6db43eab8
ERROR: Attribute ‘ene_merge_layers’/‘to_merge’ set for # without an active operation.
Source location: C:/Users/cdeluca/AppData/Roaming/SketchUp/SketchUp 2017/SketchUp/Plugins/ene_merge_layers/main.rb:60:in `add_layer_listener’
We’d love to include your extension on our warehouse, so if you’d address these items and re-submit it, we’ll review it again and get it approved.
The link to edit your extension. [<-this was a link]
Extension Review Team
First of all the lack of formatting (yes, the email looks as in the forum) makes the email really hard to parse. After reading it several times (over two days) I’ve however understood that:
- My plugin got stock in an automatic filter because it writes attributes outside of an operator.
- Someone has manually made the comment “Looks like we still have the same problem” which indicates I was supposed to already have gotten the previous piece of information.
Besides the lack of formatting there are a few bugs and other problems here.
I never got the first automatically generated email and have never ever gotten one. I have wondered for a few years now why the email you get when submitting an extensions claims that you’ll get a mail once the extension has made it through the automatic review process. There has never been such an email!
Best case-scenario: your extension passes the review and you just think the first email was sloppy written and don’t pay much attention to it. Worst case scenario: you wait for months for any sign of feedback until you give up and never try again to submit an extension.
Even once you’ve got the feedback email there’s no way to contact the reviewer for more information. The email is send from firstname.lastname@example.org, not a proper email that you can reply to. I’ve had problems with this several times when there has been bugs I haven’t been able to reproduce. I could contact ThomThom on facebook but it feels rude to contact someone privately about work, especially late at the evening and in weekends which is when I have the time to publish my extensions. I have posted about this specific issue before but got no response.
These automatic checks are also very broad and seems to gives false positives. Now that I have managed to figure out what the email meant I can understand what kind of badly made code you want to filter out. Batch operations are obviously good and marking a model as modified without user interaction is pure evil. However this feedback isn’t relevant for my plugin.I had no idea why I was seeing this for my plugin before I found the actual error message further down the email. Yes, my plugin writes attributes outside of operators. No, it’s not unkind to the undo stack and it is certainly not marking the model as modified without user interaction.
Please, start by clearly stating this being an automatic filter, then write exactly why the extension got stuck and not until then write in plain text what could have possible caused this. “Being kind to the undo stack” is irrelevant in the case of this extension. Accusing me of marking models as modified without user interaction could be taken as an insult. As it is now it really requires a a lot of knowledge and some detective work to figure out how the filter functions and what it is intended to stop before you can understand why a plugin didn’t pass the review.
I really think these issues need attention because this discourage people from making and sharing extensions. I understand that the automatic review is really complex and always will have false positives and false negatives. But please let the developer reply to the reviewer! The way the emails are written and formatted could really need some work and the missing email is clearly a bug.