I need to create this shape for a lamp.
Do you have any other pictures of it? From that image it looks to me as if you could use Intersect Faces with two cylinders and erase what isn’t the lamp.
Looks like a toroidal surface - create a donut and then cut a circle from one of the outer sides of the donut
perfect, thank you