Use "SUComponentInstanceSaveAs" get a error

623706394 · January 12, 2020, 10:39am

Hello:
I use this:

SUEntitiesRef entities = SU_INVALID;
SUModelGetEntities(model, &entities);


SUGeometryInputRef input = SU_INVALID;
SUGeometryInputCreate(&input);

SUPoint3D vertices[4] = { { 10,   10,   10 },
						{ 100, 100, 10 },
						{ 100, 100, 100 },
						{ 10,  10,   100 } };
SUGeometryInputSetVertices(input, 4, vertices);

// Add the first face
SULoopInputRef loop = SU_INVALID;
SULoopInputCreate(&loop);
SULoopInputAddVertexIndex(loop, 0);
SULoopInputAddVertexIndex(loop, 1);
SULoopInputAddVertexIndex(loop, 2);
SULoopInputAddVertexIndex(loop, 3);
size_t face_index;
SUGeometryInputAddFace(input, &loop, &face_index);


SUComponentDefinitionRef comp_def = SU_INVALID;
SUComponentDefinitionCreate(&comp_def);
SUComponentDefinitionSetName(comp_def, "CS");
SUModelAddComponentDefinitions(model, 1, &comp_def);
SUEntitiesRef comp_def_entities = SU_INVALID;
SUComponentDefinitionGetEntities(comp_def, &comp_def_entities);

SUEntitiesFill(comp_def_entities, input, true);
// Clean up geom_input
SUGeometryInputRelease(&input);

SUComponentInstanceRef instance = SU_INVALID;
SUComponentDefinitionCreateInstance(comp_def, &instance);
SUEntitiesAddInstance(entities, instance, NULL);
SUComponentInstanceSaveAs(instance, "comp.skp");
SUModelSaveToFile(model, "new_model.skp");

When I open the “comp.skp”, it has an error report，however，the “new_model.skp” is well.
the error ：
The persistence ID of the primitive CEdge (25) is out of range - fixed

The persistence ID of the primitive CVertex (26) is out of range - fixed

The persistence ID of the primitive CVertex (27) is out of range - fixed

The persistence ID of the primitive CEdge (28) is out of range - fixed

The persistence ID of the primitive CVertex (29) is out of range - fixed

The persistence ID of the primitive CEdge (30) is out of range - fixed

The persistence ID of the primitive CVertex (31) is out of range - fixed

The persistence ID of the primitive CEdge (32) is out of range - fixed

The persistence ID of the primitive CFace (33) is out of range - fixed

Where is wrong?

DanRathbun · January 12, 2020, 12:21pm

This function has serious issues:

github.com/SketchUp/api-issue-tracker

SUComponentInstanceSaveAs modifies the original instance and makes it unique

opened 03:54PM - 04 Oct 19 UTC

closed 03:51PM - 08 Feb 22 UTC

AnFunctionArray

bug wontfix C API SketchUp logged

The issue is that SUComponentInstanceGetTransform always returns identity when r…equesting on a parsed component instance from a [model skp file](https://forums.sketchup.com/uploads/short-url/aWMKUyX8PiMCa4IAIGC2CnaCjyn.skp). Consider the following code: ```cpp #include <stdio.h> #include <iostream> #include <SketchUpAPI/common.h> #include <SketchUpAPI/geometry.h> #include <SketchUpAPI/initialize.h> #include <SketchUpAPI/model/model.h> #include <SketchUpAPI/model/entities.h> #include <SketchUpAPI/model/face.h> #include <SketchUpAPI/model/edge.h> #include <SketchUpAPI/model/vertex.h> #include <SketchUpAPI/model/component_definition.h> #include <SketchUpAPI/model/component_instance.h> #include <SketchUpAPI/geometry/transformation.h> int main(int n, char **args) { // Always initialize the API before using it SUInitialize(); if (n > 1 && !strcmp(1[args], "display")) { SUModelRef model = SU_INVALID; SUModelCreateFromFile(&model, "new_model.skp"); SUEntitiesRef entities = SU_INVALID; SUModelGetEntities(model, &entities); size_t count = 0; SUEntitiesGetNumInstances(entities, &count); std::cout << "instance count: " << count << "\n"; SUComponentInstanceRef* instances = (SUComponentInstanceRef*)_alloca(count * sizeof * instances); size_t szinstances; SUEntitiesGetInstances(entities, count, instances, &szinstances); std::cout << "returned instances count: " << szinstances << "\n"; while (szinstances--) { struct SUTransformation matrix; SUComponentInstanceGetTransform(instances[szinstances], &matrix); struct FloatingPosition { double x, z, y, d; } pos = { .x = matrix.values[12], .z = matrix.values[14], .y = matrix.values[13], .d = matrix.values[15] }; printf("%f, %f, %f\n", pos.x, pos.y, pos.z); } return 0; } // Create an empty model SUModelRef model = SU_INVALID; SUResult res = SUModelCreate(&model); // It's best to always check the return code from each SU function call. // Only showing this check once to keep this example short. if (res != SU_ERROR_NONE) return 1; // Get the entity container of the model SUEntitiesRef entities = SU_INVALID; SUModelGetEntities(model, &entities); // Create a loop input describing the vertex ordering for a face's outer loop SULoopInputRef outer_loop = SU_INVALID; SULoopInputCreate(&outer_loop); for (size_t i = 0; i < 4; ++i) { SULoopInputAddVertexIndex(outer_loop, i); } // Create the face SUFaceRef face = SU_INVALID; SUPoint3D vertices[4] = { { 0, 0, 0 }, { 100, 100, 0 }, { 100, 100, 100 }, { 0, 0, 100 } }; SUFaceCreate(&face, vertices, &outer_loop); // Add the face to the entities SUComponentDefinitionRef def = SU_INVALID; SUComponentDefinitionCreate(&def); SUEntitiesRef defentities = SU_INVALID; SUComponentDefinitionGetEntities(def, &defentities); SUEntitiesAddFaces(defentities, 1, &face); SUComponentInstanceRef instance = SU_INVALID; SUComponentDefinitionCreateInstance(def, &instance); static SUTransformation matrixtransform; constexpr SUVector3D point = { 666, 666, 666 }; SUTransformationTranslation(&matrixtransform, &point); SUComponentInstanceSetTransform(instance, &matrixtransform); SUEntitiesAddInstance(entities, instance, nullptr); //comment the next line to make it work SUComponentInstanceSaveAs(instance, "instance.skp"); // Save the in-memory model to a file res = SUModelSaveToFile(model, "new_model.skp"); // Must release the model or there will be memory leaks SUModelRelease(&model); // Always terminate the API when done using it SUTerminate(); if (res != SU_ERROR_NONE) { std::cout << "Unable to save document!"; return 1; } std::cout << "Document saved!"; return 0; } ``` I'm using SDK_WIN_x64_2019-2-222. The above code will always print 0.000000, 0.000000, 0.000000 - component_instance_name - no matter if the component instance have any transformation taken in place (I exported them to skp with a transformation).

tt_su · January 21, 2020, 11:54am

Before diving deeper - can you check the return values of each SU function call? Your example doesn’t do that and will just continue even in the face of errors. Stop at the first function that gives you an error and trace back the data you are passing around.

Topic		Replies	Views
SUEntitiesFill throw the exception: Access violation reading location 0x0000000000000000 SketchUp SDK modeling	6	1813	March 20, 2019
How to connect geometry data with object definitions/instances SketchUp SDK	3	1142	December 16, 2019
Error using SUModelCreateFromFile and SUComponentInstanceSaveAs SketchUp SDK	1	498	August 15, 2020
I have a question about use SUGeometryInputRef SketchUp SDK sketchup , c-api	7	1174	December 22, 2021
Using the API to draw lines SketchUp SDK	1	1351	September 3, 2014

Use "SUComponentInstanceSaveAs" get a error

Related topics