Observer changes to model - onTransactionCommit causes Crash

[TommyK]

@tt_su

As of SU2016 the Safer Observer pattern isn’t needed. SketchUp will defer all notifications until the end of an operation. Unless you are supporting older SU versions then it’s not needed.

Aaaaaah, good to know. I was being overly careful then. Although checking an entity is valid before any operation is still a good idea, I am guessing.

@tt_su

When running into crashes in observers where the cause can be indirect I would try this:

1. Disable all other extensions and see if you still crash. (Eliminate external influence)
2. Add logging around the code you think might trigger it.

On 1. - disabling Dynamic Components resulted in no more crashes
On 2. logging around the code told me for sure that the crash happened on model.commit_operation . The ruby backtrace told me that after that, DCobservers.rbe’s onComponentAdded then instances caused the crash.

@tt_su

Do you have a complete code example that reproduce the crash. This snippet is just a fragment of the whole logic.

There is quite a lot of code that makes up the whole logic (spread across multiple files)! I wouldn’t want to bore you with going through it, but certainly in the logic components are deleted, loaded, then instances inserted.

@tt_su

(Btw, did you submit the BugSplats? Did you enter any information we can use to look it up?)

I do when I can, unfortunately, my Mac seems to be blocking Bugsplats at the moment:

Bugsplat window not available

My standard browser is Safari. It worked fine with Sketchup 2018.

@tt_su

What SketchUp version are you seeing this on?

SU 2019